diff --git a/xxl-job-admin/src/main/java/com/xxl/job/admin/controller/JobCodeController.java b/xxl-job-admin/src/main/java/com/xxl/job/admin/controller/JobCodeController.java index bc23314e..da5f25f2 100644 --- a/xxl-job-admin/src/main/java/com/xxl/job/admin/controller/JobCodeController.java +++ b/xxl-job-admin/src/main/java/com/xxl/job/admin/controller/JobCodeController.java @@ -5,6 +5,7 @@ import com.xxl.job.admin.core.model.XxlJobLogGlue; import com.xxl.job.admin.dao.IXxlJobInfoDao; import com.xxl.job.admin.dao.IXxlJobLogGlueDao; import com.xxl.job.core.biz.model.ReturnT; +import com.xxl.job.core.glue.GlueTypeEnum; import org.springframework.stereotype.Controller; import org.springframework.ui.Model; import org.springframework.web.bind.annotation.RequestMapping; @@ -35,6 +36,12 @@ public class JobCodeController { if (jobInfo == null) { throw new RuntimeException("抱歉,任务不存在."); } + if (GlueTypeEnum.BEAN == GlueTypeEnum.match(jobInfo.getGlueType())) { + throw new RuntimeException("该任务非GLUE模式."); + } + + // Glue类型-字典 + model.addAttribute("GlueTypeEnum", GlueTypeEnum.values()); model.addAttribute("jobInfo", jobInfo); model.addAttribute("jobLogGlues", jobLogGlues); @@ -48,28 +55,28 @@ public class JobCodeController { if (glueRemark==null) { return new ReturnT(500, "请输入备注"); } - if (glueRemark.length()<6 || glueRemark.length()>100) { - return new ReturnT(500, "备注长度应该在6至100之间"); + if (glueRemark.length()<4 || glueRemark.length()>100) { + return new ReturnT(500, "备注长度应该在4至100之间"); } XxlJobInfo exists_jobInfo = xxlJobInfoDao.loadById(id); if (exists_jobInfo == null) { return new ReturnT(500, "参数异常"); } - // log old code - XxlJobLogGlue xxlJobLogGlue = new XxlJobLogGlue(); - xxlJobLogGlue.setJobId(exists_jobInfo.getId()); - xxlJobLogGlue.setGlueType(exists_jobInfo.getGlueType()); - xxlJobLogGlue.setGlueSource(exists_jobInfo.getGlueSource()); - xxlJobLogGlue.setGlueRemark(exists_jobInfo.getGlueRemark()); - xxlJobLogGlueDao.save(xxlJobLogGlue); - // update new code exists_jobInfo.setGlueSource(glueSource); exists_jobInfo.setGlueRemark(glueRemark); exists_jobInfo.setGlueUpdatetime(new Date()); xxlJobInfoDao.update(exists_jobInfo); + // log old code + XxlJobLogGlue xxlJobLogGlue = new XxlJobLogGlue(); + xxlJobLogGlue.setJobId(exists_jobInfo.getId()); + xxlJobLogGlue.setGlueType(exists_jobInfo.getGlueType()); + xxlJobLogGlue.setGlueSource(glueSource); + xxlJobLogGlue.setGlueRemark(glueRemark); + xxlJobLogGlueDao.save(xxlJobLogGlue); + // remove code backup more than 30 xxlJobLogGlueDao.removeOld(exists_jobInfo.getId(), 30); diff --git a/xxl-job-admin/src/main/java/com/xxl/job/admin/service/impl/XxlJobServiceImpl.java b/xxl-job-admin/src/main/java/com/xxl/job/admin/service/impl/XxlJobServiceImpl.java index 9495431b..16e84125 100644 --- a/xxl-job-admin/src/main/java/com/xxl/job/admin/service/impl/XxlJobServiceImpl.java +++ b/xxl-job-admin/src/main/java/com/xxl/job/admin/service/impl/XxlJobServiceImpl.java @@ -79,9 +79,6 @@ public class XxlJobServiceImpl implements IXxlJobService { if (StringUtils.isBlank(jobInfo.getAuthor())) { return new ReturnT(500, "请输入“负责人”"); } - if (StringUtils.isBlank(jobInfo.getAlarmEmail())) { - return new ReturnT(500, "请输入“报警邮件”"); - } if (ExecutorRouteStrategyEnum.match(jobInfo.getExecutorRouteStrategy(), null) == null) { return new ReturnT(500, "路由策略非法"); } @@ -145,9 +142,6 @@ public class XxlJobServiceImpl implements IXxlJobService { if (StringUtils.isBlank(jobInfo.getAuthor())) { return new ReturnT(500, "请输入“负责人”"); } - if (StringUtils.isBlank(jobInfo.getAlarmEmail())) { - return new ReturnT(500, "请输入“报警邮件”"); - } if (ExecutorRouteStrategyEnum.match(jobInfo.getExecutorRouteStrategy(), null) == null) { return new ReturnT(500, "路由策略非法"); } diff --git a/xxl-job-admin/src/main/webapp/WEB-INF/template/jobcode/jobcode.index.ftl b/xxl-job-admin/src/main/webapp/WEB-INF/template/jobcode/jobcode.index.ftl index bfae3f29..a07617c7 100644 --- a/xxl-job-admin/src/main/webapp/WEB-INF/template/jobcode/jobcode.index.ftl +++ b/xxl-job-admin/src/main/webapp/WEB-INF/template/jobcode/jobcode.index.ftl @@ -26,7 +26,7 @@
<#-- icon -->
- -
+ +

@@ -188,6 +188,38 @@ public class DemoGlueJobHandler extends IJobHandler { } } + + + @@ -248,10 +280,10 @@ public class DemoGlueJobHandler extends IJobHandler {
- -
+ +

diff --git a/xxl-job-admin/src/main/webapp/WEB-INF/template/joblog/joblog.detail.ftl b/xxl-job-admin/src/main/webapp/WEB-INF/template/joblog/joblog.detail.ftl index c392ebda..f1bfcabc 100644 --- a/xxl-job-admin/src/main/webapp/WEB-INF/template/joblog/joblog.detail.ftl +++ b/xxl-job-admin/src/main/webapp/WEB-INF/template/joblog/joblog.detail.ftl @@ -14,7 +14,7 @@
<#-- icon -->