Clean Code
This commit is contained in:
parent
9b2edc8205
commit
9e4f2c6b1e
|
@ -716,6 +716,7 @@ Tips: 历史版本(V1.3.x)目前已经Release至稳定版本, 进入维护阶段
|
|||
- 2、线程模型统一;
|
||||
- 3、执行器支持手动设置执行地址列表,提供开关切换使用注册地址还是手动设置的地址;
|
||||
- 4、执行器路由规则:第一个、循环、随机、顺序故障(默认)转移;
|
||||
- 5、CleanCode,清理无效的历史参数;
|
||||
|
||||
#### TODO LIST
|
||||
- 1、支持脚本JOB(源码或指定路径), 即shell/python/php等, 日志实时输出并支持在线监控;定制JobHandler实现;
|
||||
|
|
|
@ -49,22 +49,20 @@ public class JobInfoController {
|
|||
@RequestMapping("/add")
|
||||
@ResponseBody
|
||||
public ReturnT<String> add(int jobGroup, String jobCron, String jobDesc, String author, String alarmEmail,
|
||||
String executorAppname, String executorAddress, String executorHandler, String executorParam,
|
||||
int glueSwitch, String glueSource, String glueRemark, String childJobKey) {
|
||||
String executorHandler, String executorParam, int glueSwitch, String glueSource, String glueRemark, String childJobKey) {
|
||||
|
||||
return xxlJobService.add(jobGroup, jobCron, jobDesc, author, alarmEmail,
|
||||
executorAddress, executorHandler, executorParam,
|
||||
executorHandler, executorParam,
|
||||
glueSwitch, glueSource, glueRemark, childJobKey);
|
||||
}
|
||||
|
||||
@RequestMapping("/reschedule")
|
||||
@ResponseBody
|
||||
public ReturnT<String> reschedule(int jobGroup, String jobName, String jobCron, String jobDesc, String author, String alarmEmail,
|
||||
String executorAppname, String executorAddress, String executorHandler, String executorParam,
|
||||
int glueSwitch, String childJobKey) {
|
||||
String executorHandler, String executorParam, int glueSwitch, String childJobKey) {
|
||||
|
||||
return xxlJobService.reschedule(jobGroup, jobName, jobCron, jobDesc, author, alarmEmail,
|
||||
executorAddress, executorHandler, executorParam, glueSwitch, childJobKey);
|
||||
executorHandler, executorParam, glueSwitch, childJobKey);
|
||||
}
|
||||
|
||||
@RequestMapping("/remove")
|
||||
|
|
|
@ -15,11 +15,10 @@ public interface IXxlJobService {
|
|||
public Map<String, Object> pageList(int start, int length, int jobGroup, String executorHandler, String filterTime);
|
||||
|
||||
public ReturnT<String> add(int jobGroup, String jobCron, String jobDesc, String author, String alarmEmail,
|
||||
String executorAddress, String executorHandler, String executorParam,
|
||||
int glueSwitch, String glueSource, String glueRemark, String childJobKey);
|
||||
String executorHandler, String executorParam, int glueSwitch, String glueSource, String glueRemark, String childJobKey);
|
||||
|
||||
public ReturnT<String> reschedule(int jobGroup, String jobName, String jobCron, String jobDesc, String author, String alarmEmail,
|
||||
String executorAddress, String executorHandler, String executorParam, int glueSwitch, String childJobKey);
|
||||
String executorHandler, String executorParam, int glueSwitch, String childJobKey);
|
||||
|
||||
public ReturnT<String> remove(int jobGroup, String jobName);
|
||||
|
||||
|
|
|
@ -65,7 +65,7 @@ public class XxlJobServiceImpl implements IXxlJobService {
|
|||
|
||||
@Override
|
||||
public ReturnT<String> add(int jobGroup, String jobCron, String jobDesc, String author, String alarmEmail,
|
||||
String executorAddress, String executorHandler, String executorParam,
|
||||
String executorHandler, String executorParam,
|
||||
int glueSwitch, String glueSource, String glueRemark, String childJobKey) {
|
||||
// valid
|
||||
XxlJobGroup group = xxlJobGroupDao.load(jobGroup);
|
||||
|
@ -146,7 +146,7 @@ public class XxlJobServiceImpl implements IXxlJobService {
|
|||
|
||||
@Override
|
||||
public ReturnT<String> reschedule(int jobGroup, String jobName, String jobCron, String jobDesc, String author, String alarmEmail,
|
||||
String executorAddress, String executorHandler, String executorParam, int glueSwitch, String childJobKey) {
|
||||
String executorHandler, String executorParam, int glueSwitch, String childJobKey) {
|
||||
|
||||
// valid
|
||||
XxlJobGroup group = xxlJobGroupDao.load(jobGroup);
|
||||
|
|
Loading…
Reference in New Issue