diff --git a/README.md b/README.md index 3b15ed00..3699d54c 100644 --- a/README.md +++ b/README.md @@ -88,11 +88,11 @@ XXL-JOB是一个轻量级分布式任务调度框架,其核心设计目标是 ![输入图片说明](https://static.oschina.net/uploads/img/201703/07162326_L3VB.png "在这里输入图片标题") #### 1.5 环境 -- Servlet/JSP Spec:3.0/2.2 -- Jdk:1.7+ +- JDK:1.7+ - Tomcat:7+ +- Mysql:5.6+ +- Servlet/JSP Spec:3.0/2.2 - Maven:3+ -- Mysql:5.5+ ## 二、快速入门 @@ -717,6 +717,7 @@ Tips: 历史版本(V1.3.x)目前已经Release至稳定版本, 进入维护阶段 - 3、执行器支持手动设置执行地址列表,提供开关切换使用注册地址还是手动设置的地址; - 4、执行器路由规则:第一个、循环、随机、顺序故障(默认)转移; - 5、CleanCode,清理无效的历史参数; +- 6、规范系统配置数据,通过配置文件统一管理; #### TODO LIST - 1、支持脚本JOB(源码或指定路径), 即shell/python/php等, 日志实时输出并支持在线监控;定制JobHandler实现; diff --git a/xxl-job-admin/src/main/java/com/xxl/job/admin/controller/IndexController.java b/xxl-job-admin/src/main/java/com/xxl/job/admin/controller/IndexController.java index a4923e8f..7c5350ef 100644 --- a/xxl-job-admin/src/main/java/com/xxl/job/admin/controller/IndexController.java +++ b/xxl-job-admin/src/main/java/com/xxl/job/admin/controller/IndexController.java @@ -45,8 +45,8 @@ public class IndexController { public ReturnT loginDo(HttpServletRequest request, HttpServletResponse response, String userName, String password, String ifRemember){ if (!PermissionInterceptor.ifLogin(request)) { if (StringUtils.isNotBlank(userName) && StringUtils.isNotBlank(password) - && PropertiesUtil.getString("login.username").equals(userName) - && PropertiesUtil.getString("login.password").equals(password)) { + && PropertiesUtil.getString("xxl.job.login.username").equals(userName) + && PropertiesUtil.getString("xxl.job.login.password").equals(password)) { boolean ifRem = false; if (StringUtils.isNotBlank(ifRemember) && "on".equals(ifRemember)) { ifRem = true; diff --git a/xxl-job-admin/src/main/java/com/xxl/job/admin/core/schedule/XxlJobDynamicScheduler.java b/xxl-job-admin/src/main/java/com/xxl/job/admin/core/schedule/XxlJobDynamicScheduler.java index 03550981..309e0d2a 100644 --- a/xxl-job-admin/src/main/java/com/xxl/job/admin/core/schedule/XxlJobDynamicScheduler.java +++ b/xxl-job-admin/src/main/java/com/xxl/job/admin/core/schedule/XxlJobDynamicScheduler.java @@ -35,7 +35,7 @@ public final class XxlJobDynamicScheduler implements ApplicationContextAware, In // Scheduler private static Scheduler scheduler; - public static void setScheduler(Scheduler scheduler) { + public void setScheduler(Scheduler scheduler) { XxlJobDynamicScheduler.scheduler = scheduler; } diff --git a/xxl-job-admin/src/main/java/com/xxl/job/admin/core/util/MailUtil.java b/xxl-job-admin/src/main/java/com/xxl/job/admin/core/util/MailUtil.java index edf77760..e6c4bc19 100644 --- a/xxl-job-admin/src/main/java/com/xxl/job/admin/core/util/MailUtil.java +++ b/xxl-job-admin/src/main/java/com/xxl/job/admin/core/util/MailUtil.java @@ -1,13 +1,5 @@ package com.xxl.job.admin.core.util; -import java.io.File; -import java.util.Properties; -import java.util.concurrent.ExecutorService; -import java.util.concurrent.Executors; - -import javax.mail.internet.MimeMessage; -import javax.mail.internet.MimeUtility; - import org.apache.commons.lang.ArrayUtils; import org.slf4j.Logger; import org.slf4j.LoggerFactory; @@ -15,6 +7,13 @@ import org.springframework.mail.javamail.JavaMailSender; import org.springframework.mail.javamail.JavaMailSenderImpl; import org.springframework.mail.javamail.MimeMessageHelper; +import javax.mail.internet.MimeMessage; +import javax.mail.internet.MimeUtility; +import java.io.File; +import java.util.Properties; +import java.util.concurrent.ExecutorService; +import java.util.concurrent.Executors; + /** * 邮件发送.Util * @author xuxueli 2016-3-12 15:06:20 @@ -29,12 +28,12 @@ public class MailUtil { private static String sendFrom; private static String sendNick; static{ - host = PropertiesUtil.getString("mail.host"); - port = PropertiesUtil.getString("mail.port"); - username = PropertiesUtil.getString("mail.username"); - password = PropertiesUtil.getString("mail.password"); - sendFrom = PropertiesUtil.getString("mail.sendFrom"); - sendNick = PropertiesUtil.getString("mail.sendNick"); + host = PropertiesUtil.getString("xxl.job.mail.host"); + port = PropertiesUtil.getString("xxl.job.mail.port"); + username = PropertiesUtil.getString("xxl.job.mail.username"); + password = PropertiesUtil.getString("xxl.job.mail.password"); + sendFrom = PropertiesUtil.getString("xxl.job.mail.sendFrom"); + sendNick = PropertiesUtil.getString("xxl.job.mail.sendNick"); } /** @@ -56,14 +55,14 @@ public class MailUtil { /** * 发送邮件 (完整版)(结合Spring) * - * @param javaMailSender: 发送Bean - * @param sendFrom : 发送人邮箱 - * @param sendNick : 发送人昵称 + * //@param javaMailSender: 发送Bean + * //@param sendFrom : 发送人邮箱 + * //@param sendNick : 发送人昵称 * @param toAddress : 收件人邮箱 * @param mailSubject : 邮件主题 * @param mailBody : 邮件正文 * @param mailBodyIsHtml: 邮件正文格式,true:HTML格式;false:文本格式 - * @param files[] : 附件 + * @param attachments : 附件 */ @SuppressWarnings("null") public static boolean sendMailSpring(String toAddress, String mailSubject, String mailBody, boolean mailBodyIsHtml,File[] attachments) { @@ -106,8 +105,8 @@ public class MailUtil { * @param mailSubject : 邮件主题 * @param mailBody : 邮件正文 * @param mailBodyIsHtml: 邮件正文格式,true:HTML格式;false:文本格式 - * @param inLineFile : 内嵌文件 - * @param files[] : 附件 + * //@param inLineFile : 内嵌文件 + * @param attachments : 附件 */ public static boolean sendMail (String toAddress, String mailSubject, String mailBody, boolean mailBodyIsHtml, File[] attachments){ diff --git a/xxl-job-admin/src/main/java/com/xxl/job/admin/core/util/PropertiesUtil.java b/xxl-job-admin/src/main/java/com/xxl/job/admin/core/util/PropertiesUtil.java index 67f21250..3c0c7dae 100644 --- a/xxl-job-admin/src/main/java/com/xxl/job/admin/core/util/PropertiesUtil.java +++ b/xxl-job-admin/src/main/java/com/xxl/job/admin/core/util/PropertiesUtil.java @@ -1,26 +1,25 @@ package com.xxl.job.admin.core.util; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + import java.io.FileInputStream; import java.io.IOException; import java.io.InputStreamReader; import java.net.URL; import java.util.Properties; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; - /** * properties util * @author xuxueli 2015-8-28 10:35:53 */ public class PropertiesUtil { private static Logger logger = LoggerFactory.getLogger(PropertiesUtil.class); - private static final String file_name = "config.properties"; + private static final String file_name = "xxl-job-admin.properties"; /** * load properties * @param propertyFileName - * @param ifClassPath * @return */ public static Properties loadProperties(String propertyFileName) { @@ -55,7 +54,7 @@ public class PropertiesUtil { } public static void main(String[] args) { - System.out.println(getString("triggerLogUrl")); + System.out.println(getString("xxl.job.login.username")); } } diff --git a/xxl-job-admin/src/main/resources/applicationcontext-database.xml b/xxl-job-admin/src/main/resources/applicationcontext-xxl-job-admin.xml similarity index 67% rename from xxl-job-admin/src/main/resources/applicationcontext-database.xml rename to xxl-job-admin/src/main/resources/applicationcontext-xxl-job-admin.xml index aecfd6e8..20e169ee 100644 --- a/xxl-job-admin/src/main/resources/applicationcontext-database.xml +++ b/xxl-job-admin/src/main/resources/applicationcontext-xxl-job-admin.xml @@ -1,71 +1,90 @@ - - - - - - - - - classpath*:jdbc.properties - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + classpath*:xxl-job-admin.properties + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + \ No newline at end of file diff --git a/xxl-job-admin/src/main/resources/applicationcontext-xxl-job.xml b/xxl-job-admin/src/main/resources/applicationcontext-xxl-job.xml deleted file mode 100644 index f1a96ec2..00000000 --- a/xxl-job-admin/src/main/resources/applicationcontext-xxl-job.xml +++ /dev/null @@ -1,26 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - - - \ No newline at end of file diff --git a/xxl-job-admin/src/main/resources/config.properties b/xxl-job-admin/src/main/resources/config.properties deleted file mode 100644 index 0f5e60f6..00000000 --- a/xxl-job-admin/src/main/resources/config.properties +++ /dev/null @@ -1,11 +0,0 @@ -# for email -mail.host=smtp.163.com -mail.port=25 -mail.username=ovono802302@163.com -mail.password=asdfzxcv -mail.sendFrom=ovono802302@163.com -mail.sendNick=《任务调度平台XXL-JOB》 - -# for login -login.username=admin -login.password=123456 \ No newline at end of file diff --git a/xxl-job-admin/src/main/resources/jdbc.properties b/xxl-job-admin/src/main/resources/jdbc.properties deleted file mode 100644 index 260ce72b..00000000 --- a/xxl-job-admin/src/main/resources/jdbc.properties +++ /dev/null @@ -1,4 +0,0 @@ -c3p0.driverClass=com.mysql.jdbc.Driver -c3p0.url=jdbc:mysql://localhost:3306/xxl-job?useUnicode=true&characterEncoding=UTF-8 -c3p0.user=root -c3p0.password=root_pwd \ No newline at end of file diff --git a/xxl-job-admin/src/main/resources/xxl-job-admin.properties b/xxl-job-admin/src/main/resources/xxl-job-admin.properties new file mode 100644 index 00000000..f8a53f17 --- /dev/null +++ b/xxl-job-admin/src/main/resources/xxl-job-admin.properties @@ -0,0 +1,21 @@ +### xxl-job db +xxl.job.db.driverClass=com.mysql.jdbc.Driver +xxl.job.db.url=jdbc:mysql://localhost:3306/xxl-job?useUnicode=true&characterEncoding=UTF-8 +xxl.job.db.user=root +xxl.job.db.password=root_pwd + +### xxl-job callback address +xxl.job.callBackIp= +xxl.job.callBackPort=8888 + +### xxl-job email +xxl.job.mail.host=smtp.163.com +xxl.job.mail.port=25 +xxl.job.mail.username=ovono802302@163.com +xxl.job.mail.password=asdfzxcv +xxl.job.mail.sendFrom=ovono802302@163.com +xxl.job.mail.sendNick=《任务调度平台XXL-JOB》 + +# xxl-job login +xxl.job.login.username=admin +xxl.job.login.password=123456 \ No newline at end of file