ak
/
xx-job
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Using non-final variables to lock can cause thread-safety problems.According to my understanding, it is appropriate to add the final keyword here

This commit is contained in:
paopaofish 2019-10-22 23:10:10 +08:00
parent 8bc19d443f
commit ec0ff8da86
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
xxl-job-core/src/main/java/com/xxl/job/core/util/DateUtil.java
View File

@ -24,7 +24,7 @@ public class DateUtil {
private static final String DATE_FORMAT = "yyyy-MM-dd"; private static final String DATE_FORMAT = "yyyy-MM-dd";
private static final String DATETIME_FORMAT = "yyyy-MM-dd HH:mm:ss"; private static final String DATETIME_FORMAT = "yyyy-MM-dd HH:mm:ss";
private static ThreadLocal<Map<String, DateFormat>> dateFormatThreadLocal = new ThreadLocal<Map<String, DateFormat>>(); private static final ThreadLocal<Map<String, DateFormat>> dateFormatThreadLocal = new ThreadLocal<Map<String, DateFormat>>();
private static DateFormat getDateFormat(String pattern) { private static DateFormat getDateFormat(String pattern) {
if (pattern==null || pattern.trim().length()==0) { if (pattern==null || pattern.trim().length()==0) {
throw new IllegalArgumentException("pattern cannot be empty."); throw new IllegalArgumentException("pattern cannot be empty.");